[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [XEN PATCH v3 17/23] xen/build: Start using if_changed



On Wed, Mar 04, 2020 at 05:00:28PM +0100, Jan Beulich wrote:
> On 27.02.2020 14:09, Roger Pau Monné wrote:
> > On Wed, Feb 26, 2020 at 11:33:49AM +0000, Anthony PERARD wrote:
> >> @@ -161,29 +173,47 @@ else
> >>    $(CC) $(c_flags) -c $< -o $@
> >>  endif
> >>  
> >> -%.o: %.S Makefile
> >> -  $(CC) $(a_flags) -c $< -o $@
> >> +quiet_cmd_cc_o_S = CC      $@
> >> +cmd_cc_o_S = $(CC) $(a_flags) -c $< -o $@
> >> +
> >> +%.o: %.S FORCE
> >> +  $(call if_changed,cc_o_S)
> >> +
> >> +
> >> +quiet_cmd_obj_init_o = INIT_O  $@
> > 
> > INIT_O seems kind of weird, maybe just using CHECK would be OK?
> 
> CHECK is not expressing what's going on - one could/would imply
> that the object file doesn't get changed at all, but its sections
> get renamed. I think INIT_O is sufficiently expressive at least
> to people knowing the build system.

OBJCOPY instead of INIT_O could work, since it's going to read
"OBJCOPY boot.init.o" which should be obvious enough that the object
file is generated. But I'll leave INIT_O for now.

> > The rest LGTM:
> > 
> > Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.