Re: [Xen-devel] [PATCH v2 3/5] IOMMU: iommu_igfx is x86-only

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 09 March 2020 10:44
> To: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Kevin Tian <kevin.tian@xxxxxxxxx>; Stefano Stabellini 
> <sstabellini@xxxxxxxxxx>; Julien Grall
> <julien@xxxxxxx>; Wei Liu <wl@xxxxxxx>; Konrad Wilk <konrad.wilk@xxxxxxxxxx>; 
> George Dunlap
> <George.Dunlap@xxxxxxxxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Ian 
> Jackson
> <ian.jackson@xxxxxxxxxx>; Paul Durrant <paul@xxxxxxx>
> Subject: [PATCH v2 3/5] IOMMU: iommu_igfx is x86-only
> 
> In fact it's VT-d specific, but we don't have a way yet to build code
> for just one vendor.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Paul Durrant <paul@xxxxxxx>

> 
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -32,7 +32,6 @@ bool_t __read_mostly iommu_enabled;
>  bool_t __read_mostly force_iommu;
>  bool_t __read_mostly iommu_verbose;
>  bool __read_mostly iommu_quarantine = true;
> -bool_t __read_mostly iommu_igfx = 1;
>  bool_t __read_mostly iommu_snoop = 1;
>  bool_t __read_mostly iommu_qinval = 1;
>  bool_t __read_mostly iommu_crash_disable;
> @@ -73,8 +72,10 @@ static int __init parse_iommu_param(cons
>              force_iommu = val;
>          else if ( (val = parse_boolean("quarantine", s, ss)) >= 0 )
>              iommu_quarantine = val;
> +#ifdef CONFIG_X86
>          else if ( (val = parse_boolean("igfx", s, ss)) >= 0 )
>              iommu_igfx = val;
> +#endif
>          else if ( (val = parse_boolean("verbose", s, ss)) >= 0 )
>              iommu_verbose = val;
>          else if ( (val = parse_boolean("snoop", s, ss)) >= 0 )
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -50,6 +50,8 @@ struct mapped_rmrr {
>  /* Possible unfiltered LAPIC/MSI messages from untrusted sources? */
>  bool __read_mostly untrusted_msi;
> 
> +bool __read_mostly iommu_igfx = true;
> +
>  int nr_iommus;
> 
>  static struct tasklet vtd_fault_tasklet;
> --- a/xen/include/xen/iommu.h
> +++ b/xen/include/xen/iommu.h
> @@ -53,7 +53,7 @@ static inline bool_t dfn_eq(dfn_t x, dfn
>  }
> 
>  extern bool_t iommu_enable, iommu_enabled;
> -extern bool force_iommu, iommu_quarantine, iommu_verbose, iommu_igfx;
> +extern bool force_iommu, iommu_quarantine, iommu_verbose;
>  extern bool_t iommu_snoop, iommu_qinval;
> 
>  #ifdef CONFIG_X86
> @@ -70,6 +70,7 @@ extern enum __packed iommu_intremap {
>     iommu_intremap_restricted,
>     iommu_intremap_full,
>  } iommu_intremap;
> +extern bool iommu_igfx;
>  #else
>  # define iommu_intremap false
>  #endif



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel