Re: [Xen-devel] [PATCH v4 1/3] x86/hypervisor: pass flags to hypervisor_flush_tlb

[Wei Liu <wl@xxxxxxx>]

On Mon, Mar 09, 2020 at 05:38:12PM +0100, Jan Beulich wrote:
> On 19.02.2020 12:44, Wei Liu wrote:
> > --- a/xen/include/asm-x86/flushtlb.h
> > +++ b/xen/include/asm-x86/flushtlb.h
> > @@ -123,6 +123,9 @@ void switch_cr3_cr4(unsigned long cr3, unsigned long 
> > cr4);
> >   /* Flush all HVM guests linear TLB (using ASID/VPID) */
> >  #define FLUSH_GUESTS_TLB 0x4000
> >  
> > +#define FLUSH_TLB_FLAGS_MASK (FLUSH_TLB | FLUSH_TLB_GLOBAL | 
> > FLUSH_VA_VALID | \
> > +                              FLUSH_ORDER_MASK)
> 
> I don't think FLUSH_ORDER_MASK should be part of this, as it's not
> exclusively TLB-flush related.

My intention was to capture all flags pertinent to TLB flushes. I didn't
mean they were exclusively TLB flush related.

I can remove the order mask from the list of flags. Not a big deal.

Wei.

> 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel