Re: [Xen-devel] [PATCH 5/6] mm: add 'is_special_page' macro...

["Durrant, Paul" <pdurrant@xxxxxxxxxxxx>]

> -----Original Message-----
> From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
> Sent: 28 February 2020 19:32
> To: Durrant, Paul <pdurrant@xxxxxxxxxxxx>
> Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>; Jan Beulich
> <jbeulich@xxxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Wei Liu
> <wl@xxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Ian Jackson <ian.jackson@xxxxxxxxxxxxx>;
> Julien Grall <julien@xxxxxxx>; Konrad Rzeszutek Wilk
> <konrad.wilk@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Tim
> Deegan <tim@xxxxxxx>
> Subject: Re: [PATCH 5/6] mm: add 'is_special_page' macro...
> 
> > diff --git a/xen/arch/x86/mm/mem_sharing.c
> b/xen/arch/x86/mm/mem_sharing.c
> > index 3835bc928f..c14a724c6d 100644
> > --- a/xen/arch/x86/mm/mem_sharing.c
> > +++ b/xen/arch/x86/mm/mem_sharing.c
> > @@ -842,7 +842,7 @@ static int nominate_page(struct domain *d, gfn_t
> gfn,
> >
> >      /* Skip xen heap pages */
> 
> Perhaps adjust (or remove) the comment?
>

Yes. The comment can just be dropped I think.

  Paul
 
> >      page = mfn_to_page(mfn);
> > -    if ( !page || is_xen_heap_page(page) )
> > +    if ( !page || is_special_page(page) )
> >          goto out;
> 
> Thanks,
> Tamas
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel