[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: do live patching only from main idle loop

Hi Juergen,

On 26/02/2020 14:17, Jürgen Groß wrote:
On 24.02.20 23:25, Julien Grall wrote:
Hi Juergen,

On 11/02/2020 09:31, Juergen Gross wrote:
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index 6f9bec22d3..30c4c1830b 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -23,7 +23,6 @@
  #include <xen/iocap.h>
  #include <xen/irq.h>
  #include <xen/lib.h>
-#include <xen/livepatch.h>
  #include <xen/mem_access.h>
  #include <xen/mm.h>
  #include <xen/param.h>
@@ -2239,11 +2238,6 @@ static void check_for_pcpu_work(void)
-        /*
-         * Must be the last one - as the IPI will trigger us to come here
-         * and we want to patch the hypervisor with almost no stack.
-         */
-        check_for_livepatch_work();

The check here was meant to match the x86 counterpart in reset_stack_and_jump(). I suspect you also need to remove it.

Not really, as on x86 all relevant non-idle cases are being switched
to use reset_stack_and_jump_nolp().

Ah yes, I missed that bit. Thank you for the explanation!

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.