Re: [Xen-devel] [XEN PATCH v3 20/23] xen/build: factorise generation of the linker scripts

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Wed, Feb 26, 2020 at 11:33:52AM +0000, Anthony PERARD wrote:
> In Arm and X86 makefile, generating the linker script is the same, so
> we can simply have both call the same macro.
> 
> We need to add *.lds files into extra-y so that Rules.mk can find the
> .*.cmd dependency file and load it.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>  xen/Rules.mk          | 8 ++++++++
>  xen/arch/arm/Makefile | 5 ++---
>  xen/arch/x86/Makefile | 6 +++---
>  3 files changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/xen/Rules.mk b/xen/Rules.mk
> index 8c7dba9211d1..02cd37d04054 100644
> --- a/xen/Rules.mk
> +++ b/xen/Rules.mk
> @@ -230,6 +230,14 @@ cmd_s_S = $(CPP) $(filter-out -Wa$(comma)%,$(a_flags)) 
> $< -o $@
>  %.s: %.S FORCE
>       $(call if_changed,cpp_s_S)
>  
> +# Linker scripts, .lds.S -> .lds
> +quiet_cmd_cc_lds_S = LDS     $@
> +define cmd_cc_lds_S
> +    $(CC) -P -E -Ui386 $(filter-out -Wa$(comma)%,$(a_flags)) -o $@ $<; \

Do you know why the -Ui386 is needed?

Also, can this use the CPP rune? I would at least consider naming this
CPP, as it's pre-processing the link script, LDS seems quite obscure.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel