[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [XEN PATCH v3 05/23] xen/build: Allow to test clang .include without asm symlink

On Wed, Feb 26, 2020 at 11:33:37AM +0000, Anthony PERARD wrote:
> The clang test for "asm()-s support .include." needs to be modified
> because the symbolic link asm -> asm-x86 may not exist when the test
> is runned. Since it's an x86 test, we don't need the link.
> This will be an issue with the following patch "xen/build: have the
> root Makefile generates the CFLAGS".
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

So this is just a preparatory change in order to be able to run the
checks before the headers are linked, but the current usage is
perfectly fine AFAICT? (might be worth to try to clarify the commit
message a bit in this regard).

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.