[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/build: Fix -mskip-rax-setup handling

On 21.02.2020 19:55, Andrew Cooper wrote:
> The way -mskip-rax-setup is currently specified results in compiler support
> being evaluated per translation unit, rather than per subdir.  Switch to using
> cc-add-option instead.
> This drops the number of callouts from 428 to 60.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

I have to admit that I find it odd that you post such a patch
when earlier on you've objected to my "x86: determine HAVE_AS_*
just once" because Anthony already having this work in progress.
I'm happy to see this go in independently, especially if you
really think ...

> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> This drops about 0.5s from my ccache-accelerated but otherwise-clean build,
> and will likely have a more pronounced difference on older hardware.  If it
> wants backporting, it wants to go back in this form.

... it may want backporting (of which I'm not convinced), and
seeing Anthony would be okay to re-base over it:

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

But then I'd like to ask you to re-consider your objection to
my patch as well. In particular, if this one was worth
backporting, then I guess the other one would be, too.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.