Re: [Xen-devel] [PATCH v9 3/5] xen/mem_sharing: VM forking

[Tamas K Lengyel <tamas@xxxxxxxxxxxxx>]

> > > +int mem_sharing_fork_page(struct domain *d, gfn_t gfn, bool unsharing)
> > > +{
> > > +    int rc = -ENOENT;
> > > +    shr_handle_t handle;
> > > +    struct domain *parent;
> >
> > Can you constify parent, I assume there are no changes made to the
> > parent domain, just the forked one.
>
> Sure.

Actually, no can't do. The parent could get modified here, since we
could end up making the parent's memory into shared entries. So using
const here is not justified since the parent can and does get
modified.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel