[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 3/6] public/xen.h: add a definition for a 'valid domid' mask

Paul Durrant writes ("[PATCH v6 3/6] public/xen.h: add a definition for a 
'valid domid' mask"):
> A subsequent patch will modify libxl to allow selection of a random domid
> value when creating domains. Valid values are limited to a width of 15 bits,
> so add an appropriate mask definition to the public header.

This is fine by me but I wonder if hypervisor maintainers would like
more rationale.

In the conversation where I asked you to split this out I wrote:

> >   This is useful for programs which need to [explanation],
> >   including for example, libxl, which is going to want to
> >   randomly generate domids.
> > 
> > Maybe it needs some explanation of why this belongs in the Xen
> > public headers rather than in some header available to libxc,
> > libxl and other tools stuff ?

Your commit message seems to me to explain the former but not the
latter.  I don't know if hypervisor maintainers want the latter.


Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.