[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 8/8] xen: add runtime parameter access support to hypfs

On 20.02.20 09:49, Jan Beulich wrote:
On 20.02.2020 09:22, Jürgen Groß wrote:
On 19.02.20 17:44, Jan Beulich wrote:
On 19.02.2020 09:11, Juergen Gross wrote:
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -89,6 +89,11 @@ SECTIONS
          __start_schedulers_array = .;
          __end_schedulers_array = .;
+       . = ALIGN(8);
+       __paramhypfs_start = .;
+       *(.data.paramhypfs)
+       __paramhypfs_end = .;

Do you really need 8-byte alignment even on 32-bit Arm?

I just followed the general pattern in this file.

Well, it'll be the Arm maintainers to judge anyway. It merely
caught my eye.

@@ -99,28 +101,33 @@ static int parse_gnttab_limit(const char *param, const 
char *arg,
           return -ERANGE;
*valp = val;
+    snprintf(par_val, PAR_VAL_SZ, "%lu", val);
return 0;
unsigned int __read_mostly opt_max_grant_frames = 64;
+static char gnttab_max_frames_val[PAR_VAL_SZ] = "64";

This and the other option are plain integer ones from a presentation
pov, so it would be nice to get away here without the extra buffers.

There is more than pure integer semantics here: the value is limited,
so I can't just use the normal integer assignment.

Which is why I've said "from a presentation pov", i.e. when consuming
the value for passing back as a string.

Hmm, this might even be possible via not using the common macro.
I'll have a look into it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.