Re: [Xen-devel] [PATCH v5 7/8] xen: add /buildinfo/config entry to hypervisor filesystem

[Jürgen Groß <jgross@xxxxxxxx>]

On 19.02.20 16:57, Jan Beulich wrote:
> On 19.02.2020 09:11, Juergen Gross wrote:
> > --- a/xen/common/Makefile
> > +++ b/xen/common/Makefile
> > @@ -1,6 +1,7 @@
> >   obj-$(CONFIG_ARGO) += argo.o
> >   obj-y += bitmap.o
> >   obj-y += bsearch.o
> > +obj-y += config_data.o
> In particular with embedded uses in mind, I think this wants to
> have a Kconfig control.
Okay.

> > @@ -414,6 +421,9 @@ static int __init buildinfo_init(void)
> >       hypfs_add_leaf(&version, &major, true);
> >       hypfs_add_leaf(&version, &minor, true);
> >   
> > +    config.e.size = xen_config_data_size;
> This being the only use of xen_config_data_size, it suggests that
> it could in principle live in .init.rodata. I realize this may
> mean more customization to the binfile script than is warranted
> by these 4 bytes of data, but I wanted to at least point out the
> aspect.
In case this pattern is coming up again we might want to enhance
the script, but right now I don't think this is needed.

> > --- a/xen/include/xen/kernel.h
> > +++ b/xen/include/xen/kernel.h
> > @@ -100,5 +100,8 @@ extern enum system_state {
> >   
> >   bool_t is_active_kernel_text(unsigned long addr);
> >   
> > +extern char xen_config_data;
> > +extern unsigned int xen_config_data_size;
> const for both?
Yes.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel