[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] amd/iommu: add missing unlock in iommu_read_log

On 19.02.2020 12:32, Roger Pau Monné wrote:
> On Wed, Feb 19, 2020 at 11:23:40AM +0000, Andrew Cooper wrote:
>> On 19/02/2020 11:19, Roger Pau Monne wrote:
>>> --- a/xen/drivers/passthrough/amd/iommu_init.c
>>> +++ b/xen/drivers/passthrough/amd/iommu_init.c
>>> @@ -338,6 +338,7 @@ static int iommu_read_log(struct amd_iommu *iommu,
>>>              {
>>>                  AMD_IOMMU_DEBUG("AMD-Vi: No entry written to %s Log\n",
>>>                                  log == &iommu->event_log ? "Event" : 
>>> "PPR");
>>> +                spin_unlock(&log->lock);
>> A goto out would be cleaner.  Can fix up on commit if you're happy?
> That's fine, I don't have a preference. In such cases where a simple
> unlock is required I tend to avoid the label as I know Jan prefers
> avoiding them.

I appreciate this, yet I accept others thinking differently. The
only case where I outright object to "goto" is if the target
simply does "return" or some such. Centralizing unlocking in a
single place is acceptable to me, albeit perhaps not preferred.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.