[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [OSSTEST PATCH V2] build: fix configuration of libvirt

  • To: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • From: Jim Fehlig <jfehlig@xxxxxxxx>
  • Date: Mon, 17 Feb 2020 16:41:25 -0700
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I0MFBrqhxUfZGJv3byfMZZvJP2kvdXLwJ5f+uRxYvoY=; b=XT0lNOFqHM+E4ZbU+MEjXv3JRzME2lHWfJyUHybpvDVxVJPu7MaPXecec7804qPdfGVk2adL2yYVmh7EoYBoA+ENKTSUlk1toVUmUesglTt9Vh6OaJF1P8nTepRbbmwjh+5/QwH+SaiACASSIfvwQ0lnS7c7m//NCbnA2ZbnqXhd7QGlAyBQK00V7cgEYNnx+XxdTQkS4XWSIY4ALoE5EoHLHdA+Otu7UO+OIOnhGl6mhjqQg4fhKeIimze/gdxYdLGvgs3FfTntjhp9R+hTEJ8tcw9wIuL0lUpDJ8CzCJuWSZ9MGNrd9Dq08LvEhtPxCiHUlpz7KCHsSnCSK6d4mw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wu9HOLM3qLZsWZoGp/19UaS1n1T9vVWI0o2RPHZRy2kUtXrSUxrN1T7dn6hmNwALA16rudm7lXAtD6XcjUoH/yperLs+rOHbCNLIQ+OeRlP8aAKtIsCHvr0fc8VuaFgYa9t4VHKV1sAjx3lchFHcp1+IvV1/4ixdhTF9lmadCbbJgmfmAAUW3xvPeij76H1eUvp0xNmS6IeExPaMdfMzTcdaJAZwafFhto2k6HZlXgsW8D05Y5oITaCgdszgE3mmeuMh6Dcm6fe+OjmtOnChzLQca6rhXMurQ0cHuzQANnAJ6WEhSC6PLvdaUhb3jdVVF4X7r+zVUst7Ri+zXjSkgw==
  • Authentication-results: spf=none (sender IP is ) smtp.mailfrom=jfehlig@xxxxxxxx;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 17 Feb 2020 23:46:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2/14/20 10:47 AM, Ian Jackson wrote:
Jim Fehlig writes ("[OSSTEST PATCH V2] build: fix configuration of libvirt"):
libvirt.git commit 2621d48f00 removed the last traces of gnulib, which
also removed the '--no-git' option from autogen.sh. Unknown options are
now passed to the configure script, which quickly fails with

   configure: error: unrecognized option: `--no-git'

Remove the gnulib handling from ts-libvirt-build, including the '--no-git'
option to autogen.sh. While at it remove configure options no longer
supported by the libvirt configure script.

Harmf.  Thanks for looking into this and trying to fix this mess.

I think there is a problem with your patch, which is that 2621d48f00
is recent enough that we might want still to be able to build with
earlier versions.

Ah, good point.

Is there an easy way to tell (by looking at the tree after checkout,
maybe) whether to do the old or the new thing ?

There would be no gnulib directory in a tree checked out after commit 2621d48f00. Another option is to check for the 'bootstrap' script in the root of the tree, which was removed by 2621d48f00.

Your perl code looks good to me for what it is trying to do.

I'm afraid my perl is too weak to quickly hack something up to support both pre and post gnulib builds :-(. I'll add this task to my list if you don't have time for it.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.