Re: [Xen-devel] [PATCH] xen/x86: p2m: Don't initialize slot 0 of the P2M

[Julien Grall <julien@xxxxxxx>]

Hi George,

On 06/02/2020 12:08, George Dunlap wrote:
> On 2/3/20 4:58 PM, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > It is not entirely clear why the slot 0 of each p2m should be populated
> > with empty page-tables. The commit introducing it 759af8e3800 "[HVM]
> > Fix 64-bit HVM domain creation." does not contain meaningful
> > explanation except that it was necessary for shadow.
> >
> > As we don't seem to have a good explanation why this is there, drop the
> > code completely.
> >
> > This was tested by successfully booting a HVM with shadow enabled.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Since nobody knows why it's here, and it doesn't look like it should
> have any effect:
>
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>
Thank you! I have now committed the patch.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel