Re: [Xen-devel] [PATCH] xen/sched: remove pointless ASSERT() in credit2

[Jürgen Groß <jgross@xxxxxxxx>]

On 11.02.20 10:29, Dario Faggioli wrote:
> On Mon, 2020-02-10 at 17:45 +0100, Juergen Gross wrote:
> > The ASSERT() at the top of csched2_context_saved() is completely
> > pointless, as the BUG_ON() just in front of it catches the same
> > problem
> > already.
> Yep, I went double checking and this is my fault. :-(
>
> Apparently, in ccf2ead7f52 ("xen: credit2: make the code less
> experimental"), for this specific case, I added the assert but forgot
> to remove the BUG_ON().
>
> Thanks for noticing and acting on this. :-)
>
> TBH, though, considering the nature of the check, I'd rather keep the
> ASSERT() and kill the BUG_ON().
>
> I can do the patch myself if you don't want to respin it that way.
I'll respin.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel