Re: [Xen-devel] [PATCH v2 4/4] AMD/IOMMU: Treat head/tail pointers as byte offsets

[Jan Beulich <jbeulich@xxxxxxxx>]

On 10.02.2020 18:33, Andrew Cooper wrote:
> The MMIO registers as already byte offsets.  Using them in this form removes
> the need to shift their values for use.
> 
> It is also inefficient to store both entries and alloc_size (which only differ
> by entry_size).  Rename alloc_size to size, and drop entries entirely, which
> simplifies the allocation/deallocation helpers slightly.
> 
> Mark send_iommu_command() and invalidate_iommu_all() as static, as they have
> no external declaration or callers.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> 
> v2:
>  * Mask head/tail pointers
>  * Drop unnecessary cast.

Thanks for adjusting these.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel