[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/pvh: Fix segment selector ABI

On Sat, Feb 08, 2020 at 03:19:39PM +0000, Andrew Cooper wrote:
> The written ABI states that %es will be set up, but libxc doesn't do so.  In
> practice, it breaks `rep movs` inside guests before they reload %es.
> The written ABI doesn't mention %ss, but libxc does set it up.  Having %ds
> different to %ss is obnoxous to work with, as different registers have
> different implicit segments.
> Modify the spec to state that %ss is set up as a flat read/write segment.
> This a) matches the Multiboot 1 spec, b) matches what is set up in practice,
> and c) is the more sane behaviour for guests to use.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Wei Liu <wl@xxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.