Re: [Xen-devel] [PATCH] xen/include: public: Document the padding in struct xen_hvm_param

[Jan Beulich <jbeulich@xxxxxxxx>]

On 06.02.2020 16:41, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> There is an implicit padding of 2 bytes in struct xen_hvm_param between
> the field domid and index. Make it explicit by introduce a padding
> field. This can also serve as documentation.
> 
> Note that I don't think we can mandate it to be zero because a guest may
> not have initialized the padding.

Agreed - we can mandate such only at introduction, not at any
later time.

> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

(I doubt this is the only missing field to make padding explicit.)

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel