Re: [Xen-devel] [PATCH 4/6] sysctl: use xmalloc_array() for XEN_SYSCTL_page_offline_op

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 05/02/2020 16:38, Jan Beulich wrote:
> On 05.02.2020 15:34, Julien Grall wrote:
> > On 05/02/2020 13:16, Jan Beulich wrote:
> > > This is more robust than the raw xmalloc_bytes().
> > >
> > > Also add a sanity check on the input page range.
> > It feels to me that the commit message/title should focus on the sanity
> > check. The xmalloc_array() is just a cleanup is "less important".
> But it not being there would generally just result in -ENOMEM
> due to the xmalloc_...() failing (leaving aside overflow not
> accounted for in the old code), which by the new check just
> gets changed into the more applicable -EINVAL. I view the
> changed called out in the title as more important.
None of the commit message really explain this. So the sanity check did 
feel more important.
You probably want to reword the commit message to explain why the sanity 
check is added (i.e ENOMEM vs EINVAL).
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel