Re: [Xen-devel] [PATCH] x86/domain_page: implement pure per-vCPU mapping infrastructure

[Wei Liu <wl@xxxxxxx>]

On Tue, Feb 04, 2020 at 04:02:38PM +0000, Xia, Hongyan wrote:
[...]
> > Keep in mind that accessing the union {pv, hvm} before knowing the
> > exact variant is dangerous.
> > 
> > Because mapcache is initialised for PV only, so it should be freed
> > for
> > PV only. I think you need to put it to pv_vcpu_destroy.
> > 
> > If you don't want to do that because of asymmetry with
> > mapcache_vcpu_init, you may want to invent mapcache_vcpu_destroy for
> > your purpose.
> 
> Ah right this is a problem. I was working on a tree where everyone has
> a mapcache, which is not true for current upstream when I cherry-
> picked. Will fix.
> 

If the future direction is for both hvm and pv to have a mapcache (?)
then I would certainly recommend inventing a mapcache_vcpu_destroy.

Wei.

> Hongyan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel