Re: [Xen-devel] [PATCH v3 7/9] xen: provide version information in hypfs

[Jürgen Groß <jgross@xxxxxxxx>]

On 03.02.20 18:02, Jan Beulich wrote:
> On 21.01.2020 09:43, Juergen Gross wrote:
> > Provide version and compile information in /buildinfo/ node of the
> > Xen hypervisor file system. As this information is accessible by dom0
> > only no additional security problem arises.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> with on suggestion:
>
> > @@ -373,6 +374,50 @@ void __init do_initcalls(void)
> >           (*call)();
> >   }
> >   
> > +static unsigned int major_version;
> > +static unsigned int minor_version;
> > +
> > +static HYPFS_DIR_INIT(buildinfo, "buildinfo");
> > +static HYPFS_DIR_INIT(compileinfo, "compileinfo");
> > +static HYPFS_DIR_INIT(version, "version");
> > +static HYPFS_UINT_INIT(major, "major", major_version);
> > +static HYPFS_UINT_INIT(minor, "minor", minor_version);
> > +static HYPFS_STRING_INIT(changeset, "changeset");
> > +static HYPFS_STRING_INIT(compiler, "compiler");
> > +static HYPFS_STRING_INIT(compile_by, "compile_by");
> > +static HYPFS_STRING_INIT(compile_date, "compile_date");
> > +static HYPFS_STRING_INIT(compile_domain, "compile_domain");
> > +static HYPFS_STRING_INIT(extra, "extra");
> Please consider making all of the above __read_mostly.
Okay.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel