Re: [Xen-devel] [PATCH v7 4/7] x86/mem_sharing: use default_access in add_to_physmap

[Jan Beulich <jbeulich@xxxxxxxx>]

On 03.02.2020 17:12, Tamas K Lengyel wrote:
> When plugging a hole in the target physmap don't use the access permission
> returned by __get_gfn_type_access as it is non-sensical (p2m_access_n) in
> the use-case add_to_physmap was intended to be used in. It leads to vm_events
> being sent out for access violations at unexpected locations. Make use of
> p2m->default_access instead and document the ambiguity surrounding "hole"
> types and corner-cases with custom mem_access being set on holes.
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

> ---
> v7: add detailed comment explaining the issue and why this fix is correct

Thanks for this addition.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel