Re: [Xen-devel] [PATCH v6 01/11] x86/hypervisor: make hypervisor_ap_setup return an error code

[Wei Liu <wl@xxxxxxx>]

On Mon, Feb 03, 2020 at 01:56:48PM +0100, Jan Beulich wrote:
> On 31.01.2020 18:49, Wei Liu wrote:
> > We want to be able to handle AP setup error in the upper layer.
> > 
> > Signed-off-by: Wei Liu <liuwe@xxxxxxxxxxxxx>
> > ---
> > v6:
> > 1. Change map_vcpuinfo as well
> 
> And by implication then ...
> 
> > @@ -257,11 +257,17 @@ static void __init setup(void)
> >      init_evtchn();
> >  }
> >  
> > -static void ap_setup(void)
> > +static int ap_setup(void)
> >  {
> > +    int rc;
> > +
> >      set_vcpu_id();
> > -    map_vcpuinfo();
> > -    init_evtchn();
> > +    rc = map_vcpuinfo();
> > +
> > +    if ( !rc )
> > +        init_evtchn();
> 
> ... init_evtchn() as well?

OK. I can change that too.

Wei.

> 
> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel