[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] EPT: do away with hidden GUEST_TABLE_MAP_FAILED == 0 assumptions

> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Saturday, January 18, 2020 12:36 AM
> The code is quite a bit easier to read and to reason about this way,
> I think.
> In ept_set_entry() additionally change the function's return value in
> the MAP_FAILED case to -ENOMEM; -ENOENT would be applicable only when
> ept_next_entry() was invoked with "read_only" set to true.
> In two cases, where ept_next_level() follows an ept_split_superpage()
> invocation, actually tighten the loop exit condition from
> "== MAP_FAILED" to "!= NORMAL_PAGE". Continuing these loops for other
> than NORMAL_PAGE is invalid, and there are ASSERT()s in place after
> these loops.
> Also reduce the scope of "ret" variables where possible, in particular
> to better distinguish them from "rc" often used in the same function.
> Finally drop pointless "else" in a few areas touched anyway.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.