Re: [Xen-devel] [PATCH v3 3/6] libxl: add infrastructure to track and query 'retired' domids

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Durrant, Paul writes ("RE: [PATCH v3 3/6] libxl: add infrastructure to track 
and query 'retired' domids"):
> [Ian;]
> > I'm not sure why you bother with fgets into a buffer, when you could
> > just use fscanf rather than sscanf.  Your code doesn't need to take
> > much care about weird syntax which might occur (and indeed your code
> > here doesn't take such care).
> 
> Well, I need to pull the line into a buffer if I'm going to write it out 
> again, but otherwise I could indeed use fscanf().

Well, you could just fprintf the information.

> Ok, 'recent' is probably clearer. I'll s/retired/recent/g.

Thanks.

> > I don't much like the environment variable to configure this.  I don't
> > object to keeping it but can we have a comment saying this is not
> > intended for use in production ?  Personally I would rather it was
> > hardcoded, or failing that, written to some config file.
> 
> The problem is that libxl has no config file. Env variables seem to be used 
> for other things so I followed suit. I'd rather keep the override for debug 
> purposes; I'll stick a comment in the header saying that's what it's for 
> though, as you suggest.

OK.  You are right about the lack of a config file being a problem.

> > Finally, I think this patch needs an addition to xen-init-dom0 to
> > remove or empty the record file.  This is because while /run is
> > usually a tmpfs, this is not *necessarily* true.
> 
> Ok, if we cannot rely on it being tmpfs then I will do that.

Thanks.

Thanks for the rest of your reply, too, which I snipped as I had
nothing more to say than `thanks'.

Regards,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel