Re: [Xen-devel] [PATCH v4 06/18] x86/mem_sharing: define mem_sharing_domain to hold some scattered variables

[Jan Beulich <jbeulich@xxxxxxxx>]

On 08.01.2020 18:14, Tamas K Lengyel wrote:
> Create struct mem_sharing_domain under hvm_domain and move mem sharing
> variables into it from p2m_domain and hvm_domain.
> 
> Expose the mem_sharing_enabled macro to be used consistently across Xen.
> 
> Remove some duplicate calls to mem_sharing_enabled in mem_sharing.c
> 
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with one question:

> @@ -192,6 +192,10 @@ struct hvm_domain {
>          struct vmx_domain vmx;
>          struct svm_domain svm;
>      };
> +
> +#ifdef CONFIG_MEM_SHARING
> +    struct mem_sharing_domain mem_sharing;
> +#endif

Are you intending to add fields to this new struct? If so,
should the field here become a pointer, and the structure
allocated only when actually needed?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel