[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 12/12] libxc/save: Write X86_{CPUID, MSR}_DATA records


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Tue, 14 Jan 2020 17:21:40 +0000
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 14 Jan 2020 17:21:58 +0000
  • Ironport-sdr: I3EQ3MwBueKiH4a4O5UfA8V+cNCw5ze+uK+TKoEks5akcsJofw9oPenZgjmnC/WHCHTWANfSh3 emffovKZpzGP5dwlf0PdJBil1FcbuAIy9e2ye4WKmpnXV1urvOK27MogOmTdlYwsY75GDKSGiR pGcNLxxhjsAjBHYoLLdQ9r0fnlNCyM0KRDZBtkfEf0RovMGy5qtr1BudhMRH48SvSCJ18jRmop krBTE24BKxbAJvLW+tPsWgEybHWa4M9tqfrIJ1DQc6zqQKusBrmP+kyih+/DLm/uTdWJ+U6wWZ 4sQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Andrew Cooper writes ("[PATCH 12/12] libxc/save: Write X86_{CPUID,MSR}_DATA 
records"):
> With all other plumbing in place, obtain the CPU Policy from Xen and
> write it into the migration stream.

This looks good to me but:

This patch may need revision to handle the results of our discussion
about the ?: error handling idiom.

And I am still missing the text discussing compatibility.  Maybe I
have just overlooked it ?

Anyway, if it weren't for those two issues I would have acked the
patch.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.