[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [BUG] scripts/add_maintainers.pl adding empty Cc: lines


  • To: Jürgen Groß <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Lars Kurth <lars.kurth@xxxxxxxxxx>
  • Date: Fri, 10 Jan 2020 16:44:21 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=lars.kurth@xxxxxxxxxx; spf=Pass smtp.mailfrom=lars.kurth@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Delivery-date: Fri, 10 Jan 2020 16:44:36 +0000
  • Ironport-sdr: MvyTt4xu3CtHSjClGSEDmb8T9JcenfR6CgpT6YORDOUsqg5/eKj1uXoafLCa5uknpsWjrun+Zx 7ecAS+R9IqrUhTnrfFrbrwLazxvIDIMl2kE0kOK+afjO5MBNwKggwGjHDXMQUfF08YkzB438Kb h9ofRdz9lDyK4ezvwBZeiu7Z08ezMsbEkFfzLSBL/bwIV8QhFcsI6OiH3L54bAi0kC4Bz4qPJF lRNP4g2em7G+jgMrgw9rnoiIhSJVsSNmwoa8W2NKhkCJpRYVw13GFKMr+3Qse7lYAjwli2P4qY HZk=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHVx9U1WsAOauSM5EeJ46Ka5RJjXQ==
  • Thread-topic: [BUG] scripts/add_maintainers.pl adding empty Cc: lines


On 08/01/2020, 16:52, "Jürgen Groß" <jgross@xxxxxxxx> wrote:

    Just had a chat with Lars on IRC, which might be of common
    interest (and Lars asked me to post it to xen-devel):
    
    (17:00:16) juergen_gross: lars_kurth: any idea why 
    ./scripts/add_maintainers.pl would add a "Cc:" without a mail address to 
    a patch? Happened e.g. in my series "[PATCH v2 0/9] xen: scheduler 
    cleanups" (cover-letter, patches 1, 2, 7 and 9)
    (17:01:58) lars_kurth: juergen_gross: oh, an actual bug! Let me look at 
    the code
    (17:02:19) lars_kurth: juergen_gross:  is it missing some e-mails?
    (17:02:34) juergen_gross: git send-email seems to remove those empty Cc: 
    lines
    (17:02:53) juergen_gross: I'm not aware of a mail address missing. Let 
    me double check
    (17:06:56) juergen_gross: lars_kurth: hmm, shouldn't the MAINTAINERS 
    entry "L:      DornerWorks Xen-Devel <xen-devel@xxxxxxxxxxxxxxx>" result 
    in a Cc:?
    (17:08:17) lars_kurth: Let me have a look
    (17:13:16) juergen_gross: lars_kurth: at least the related file is 
    touched exactly by the affected patches (and not by any not affected patch)
    (17:13:36) lars_kurth: Looking at the series the most likely cause of 
    this is the L: entry - need to look at the code
    (17:15:21) lars_kurth: juergen_gross: it's also an odd one because it 
    changes MAINTAINERS and renames a lot of files, which may be the cause 
    for the empty spaces
    (17:15:52) juergen_gross: lars_kurth: in Linux MAINTAINERS all "L:" 
    entries just have a mail address as first word after the "L:" (not "bla 
    bla <addr@domain>")
    (17:16:11) lars_kurth: Ah yes: let me look at that code
    (17:21:29) lars_kurth: juergen_gross: I think that is in fact the issue
    (17:27:16) lars_kurth: juergen_gross: I can't fix this with some 
    debugging. Could you copy this conversation into a mail on xen-devel@ 
    such that I remember
    (17:27:43) lars_kurth: uergen_gross: with=without
    (17:29:36) lars_kurth:  juergen_gross: I think what happens is that 
    get_maintainer.pl and add_maintainer.pl process these lines differently, 
    but add_maintainer.pl also checks against output created from 
    get_maintainer.pl
    (17:44:58) juergen_gross: lars_kurth: what about doing it the easy way? 
    With a modifed MAINTAINERS file (using "L: xen-devel@xxxxxxxxxxxxxxx") 
    everything is fine. I can send a patch in case you agree.
    (17:46:41) lars_kurth: juergen_gross: let's do that first, but I still 
    would like to fix the underlying issue at some point - asking for you to 
    send the IRC log, as I cleared my history by mistake (when I was typing 
    a reply I slipped from shift to ctrl, which did it)
    
    
For my own reference, the issue is somewhere in get_maintainer.pl, not in 
add_maintainers.pl

In a nutshell, a line such as
L: foo bar <e-mail address> in MAINTAINERS

Will produce an empty line when executing sth like ./scripts/get_maintainer.pl 
< ../patches/test/0001-Add-test-case.patch

In the test case I used, I use
L: xxx yyy <xxx@xxxxxxxxxxxxxxxxxxxx> in MAINTAINERS
and get
Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
...
Wei Liu <wl@xxxxxxx>

xen-devel@xxxxxxxxxxxxxxxxxxxx

When I use
L: xxx@xxxxxxxxxxxxxxxxxxxx in MAINTAINERS
I get
Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
...
Wei Liu <wl@xxxxxxx>
xxx@xxxxxxxxxxxxxxxxxxxx
xen-devel@xxxxxxxxxxxxxxxxxxxx

Need to investigate further
Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.