Re: [Xen-devel] [PATCH] xen: make CONFIG_DEBUG_LOCKS usable without CONFIG_DEBUG

[Jürgen Groß <jgross@xxxxxxxx>]

On 09.01.20 11:07, George Dunlap wrote:
> On 1/9/20 5:40 AM, Juergen Gross wrote:
> > In expert mode it is possible to enable CONFIG_DEBUG_LOCKS without
> > having enabled CONFIG_DEBUG. The coding is depending on CONFIG_DEBUG
> > as it is using ASSERT(), however.
> Any reason not to use BUG_ON() in that case?
The main reason is the missing message which condition failed.

A rename ("BUG_ASSERT"?) could be an alternative to just dropping
the message. Both would be fine with me.

> Having two different asserts is almost certainly going to cause bugs.
Obviously having only one is enough for bugs already. ;-)


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel