[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] libxc/restore: Fix data auditing in handle_x86_pv_info()

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Ian Jackson <ian.jackson@xxxxxxxxxx>
  • Date: Fri, 20 Dec 2019 12:08:49 +0000
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=ian.jackson@xxxxxxxxxx; spf=Pass smtp.mailfrom=Ian.Jackson@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Fri, 20 Dec 2019 12:09:13 +0000
  • Ironport-sdr: WVL+h7KHpkeU5taY2mh8GlBaoysFEA62xrjidS5rUorICd7RFIZTcN/lYDfN4m44zXdwSoda5x sc+Z+zh/BDtSI08h/LB2JdqDUlT3XTTIIi1d9xG1WGeI/KscsswM05742rAXM5lo2IxmCBuxak /lD2brr/wRzCHNbES9U8dS915fpSNxLD1i2nu4bwo3sPP0c8nhMe2M0DQPi9bALXgzrLxFXjwy Ga+TM376uUaPZIT0Nd+A14oIW9nOYb91+Gcoo7Sf0drB2BH7j/Juh8hh7tod6BhN2ZToTDDBif aAE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Andrew Cooper writes ("[PATCH] libxc/restore: Fix data auditing in 
> handle_x86_pv_info() has a subtle bug.  It uses an 'else if' chain with a
> clause in the middle which doesn't exit unconditionally.  In practice, this
> means that when restoring a 32bit PV guest, later sanity checks are skipped.
> Rework the logic a little to be simpler.  There are exactly two valid
> combinations of fields in X86_PV_INFO, so factor this out and check them all
> in one go, before making adjustments to the current domain.
> Once adjustments have been completed successfully, sanity check the result
> against the X86_PV_INFO settings in one go, rather than piecewise.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.