Re: [Xen-devel] [PATCH] x86/save: reserve HVM save record numbers that have been consumed...

[Jan Beulich <jbeulich@xxxxxxxx>]

On 18.12.2019 17:09, Paul Durrant wrote:
> --- a/xen/include/public/arch-x86/hvm/save.h
> +++ b/xen/include/public/arch-x86/hvm/save.h
> @@ -639,10 +639,12 @@ struct hvm_msr {
>  
>  #define CPU_MSR_CODE  20
>  
> +/* Range 22 - 40 reserved for Amazon */
> +
>  /*
>   * Largest type-code in use
>   */
> -#define HVM_SAVE_CODE_MAX 20
> +#define HVM_SAVE_CODE_MAX 40

I'm not overly happy to see the respective in-Xen array double its
size for no use at all. I also don't think out-of-tree extensions
should have been added using numbers consecutive to the upstream
ones. Instead, an Amazon range should have been picked high up in
the number space (e.g. with the upper byte being ASCII 'A').

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel