Re: [Xen-devel] [PATCH] tools/python: Python 3 compatibility

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Dec 18, 2019 at 10:32:47PM +0000, Andrew Cooper wrote:
> On 18/12/2019 22:26, Marek Marczykowski-Górecki wrote:
> >> @@ -70,7 +73,7 @@ class VM(object):
> >>  
> >>          # libxl
> >>          self.libxl = fmt == "libxl"
> >> -        self.emu_xenstore = "" # NUL terminated key&val pairs from 
> >> "toolstack" records
> >> +        self.emu_xenstore = b"" # NUL terminated key&val pairs from 
> >> "toolstack" records
> >>  
> >>  def write_libxc_ihdr():
> >>      stream_write(pack(libxc.IHDR_FORMAT,
> > You also need to update write_record (string constants).
> > And few calls to it with string constants (write_libxl_end,
> > write_libxl_libxc_context, read_pv_tail, read_hvm_tail).
> > And blkid == ... in read_pv_extended_info().
> 
> Urgh - well spotted.
> 
> Was this manual inspection, or something else? 

Manual search for " and '.

> (I probably should
> complete and upstream write-legacy-stream for the purpose of dev-testing
> the convert-legacy-stream script now that 4.6 is waaay in the past.)
> 
> ~Andrew

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel