[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 1/9] xen/sched: move schedulers and cpupool coding to dedicated directory
 
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
 
- From: Jürgen Groß <jgross@xxxxxxxx>
 
- Date: Wed, 18 Dec 2019 10:16:33 +0100
 
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Josh Whitehead <josh.whitehead@xxxxxxxxxxxxxxx>, Meng Xu <mengxu@xxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stewart Hildebrand <stewart.hildebrand@xxxxxxxxxxxxxxx>
 
- Delivery-date: Wed, 18 Dec 2019 09:16:47 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
On 18.12.19 10:08, Andrew Cooper wrote:
 
On 18/12/2019 08:58, Dario Faggioli wrote:
 
On Wed, 2019-12-18 at 08:48 +0100, Juergen Gross wrote:
 
Move sched*c and cpupool.c to a new directory common/sched.
Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
---
  MAINTAINERS                                        |  8 +--
  xen/common/Kconfig                                 | 66 +-----------
----------
  xen/common/Makefile                                |  8 +--
  xen/common/sched/Kconfig                           | 65
+++++++++++++++++++++
  xen/common/sched/Makefile                          |  7 +++
  .../{compat/schedule.c => sched/compat_schedule.c} |  2 +-
  xen/common/{ => sched}/cpupool.c                   |  0
  xen/common/{ => sched}/sched_arinc653.c            |  0
  xen/common/{ => sched}/sched_credit.c              |  0
  xen/common/{ => sched}/sched_credit2.c             |  0
  xen/common/{ => sched}/sched_null.c                |  0
  xen/common/{ => sched}/sched_rt.c                  |  0
  xen/common/{ => sched}/schedule.c                  |  2 +-
  13 files changed, 80 insertions(+), 78 deletions(-)
  create mode 100644 xen/common/sched/Kconfig
  create mode 100644 xen/common/sched/Makefile
  rename xen/common/{compat/schedule.c => sched/compat_schedule.c}
(97%)
  rename xen/common/{ => sched}/cpupool.c (100%)
  rename xen/common/{ => sched}/sched_arinc653.c (100%)
  rename xen/common/{ => sched}/sched_credit.c (100%)
  rename xen/common/{ => sched}/sched_credit2.c (100%)
  rename xen/common/{ => sched}/sched_null.c (100%)
  rename xen/common/{ => sched}/sched_rt.c (100%)
  rename xen/common/{ => sched}/schedule.c (99%)
 
Matter of taste, I guess, but what about not repeating 'sched', i.e.:
xen/common/sched_credit.c  --> xen/common/sched/credit.c
xen/common/sched_credit2.c --> xen/common/sched/credit2.c
xen/common/sched_null.c    --> xen/common/sched/null.c
...
schedule.c can be called something like 'core.c',
 
 
+1 FWIW, and compat_schedule.c can just become compat.c
 
 
Yes, indeed.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel 
 
    
     |