[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] Tidy up whitespace and formatting in file to be consistent.

On Tue, Dec 17, 2019 at 02:13:30PM +0000, Wei Liu wrote:
> On Fri, Dec 13, 2019 at 03:08:34PM +1100, Steven Haigh wrote:
> > Signed-off-by: Steven Haigh <netwiz@xxxxxxxxx>
> Acked-by: Wei Liu <wl@xxxxxxx>
> I will need to add tools/hotplug to the subject line and the following
> commit message:
>    Use 4 spaces for indentation throughout the file. No functional
>    change.

Actually you used tabs not spaces.

Going through other files in the same directories, they all use spaces
-- although they are as messy as this one file your modified.

While I try really hard to avoid bikeshedding space vs tab, I do want
those files to be consistent, so I will take the all-or-nothing approach
here. I probably won't commit this patch unless there is a very good
reason for it to be committed...


> Wei.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.