[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 3/6] x86/suspend: Don't save unnecessary GPRs
On Tue, Dec 17, 2019 at 12:10:55PM +0000, Andrew Cooper wrote: > On 17/12/2019 12:04, Roger Pau Monné wrote: > >> diff --git a/xen/arch/x86/acpi/wakeup_prot.S > >> b/xen/arch/x86/acpi/wakeup_prot.S > >> index 35fd7a5e9f..2f6c8e18ef 100644 > >> --- a/xen/arch/x86/acpi/wakeup_prot.S > >> +++ b/xen/arch/x86/acpi/wakeup_prot.S > >> @@ -11,24 +11,14 @@ > >> #define REF(x) x(%rip) > >> > >> ENTRY(do_suspend_lowlevel) > >> + push %rbp > >> + push %rbx > >> + push %r12 > >> + push %r13 > >> + push %r14 > >> + push %r15 > > I was expecting Xen had a macro for this (and the restore > > counterpart), but I haven't found any (neither any other places where > > it would be useful). > > We have macros for saving and restoring all GPRs as part of an > exception, but this is just regular function prologue/epilogue logic > (which happens to be hand written asm because this function isn't quite > a regular function). Yes, I've found SAVE_ALL, but as you say that's overkill (and it's partly what you are trying to avoid here). Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |