[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 1/6] arm/arm64/xen: hypercall.h add includes guards


On 04/12/2019 23:20, Pavel Tatashin wrote:
The arm and arm64 versions of hypercall.h are missing the include
guards. This is needed because C inlines for privcmd_call are going to
be added to the files.

Also fix a comment.

Signed-off-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
  arch/arm/include/asm/assembler.h       | 2 +-
  arch/arm/include/asm/xen/hypercall.h   | 4 ++++
  arch/arm64/include/asm/xen/hypercall.h | 4 ++++
  include/xen/arm/hypercall.h            | 6 +++---
  4 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/arch/arm/include/asm/assembler.h b/arch/arm/include/asm/assembler.h
index 99929122dad7..8e9262a0f016 100644
--- a/arch/arm/include/asm/assembler.h
+++ b/arch/arm/include/asm/assembler.h
@@ -480,7 +480,7 @@ THUMB(      orr     \reg , \reg , #PSR_T_BIT        )
        .macro  uaccess_disable, tmp, isb=1
-        * Whenever we re-enter userspace, the domains should always be
+        * Whenever we re-enter kernel, the domains should always be

This feels unrelated from the rest of the patch and probably want an explanation. So I think this want to be in a separate patch.

The rest of the patch looks good to me.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.