[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v4 1/6] arm/arm64/xen: hypercall.h add includes guards
- To: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>, jmorris@xxxxxxxxx, sashal@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, catalin.marinas@xxxxxxx, will@xxxxxxxxxx, steve.capper@xxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, maz@xxxxxxxxxx, james.morse@xxxxxxx, vladimir.murzin@xxxxxxx, mark.rutland@xxxxxxx, tglx@xxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, allison@xxxxxxxxxxx, info@xxxxxxxxx, alexios.zavras@xxxxxxxxx, sstabellini@xxxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, jgross@xxxxxxxx, stefan@xxxxxxxx, yamada.masahiro@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux@xxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Mon, 16 Dec 2019 20:36:23 +0000
- Delivery-date: Mon, 16 Dec 2019 20:36:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 04/12/2019 23:20, Pavel Tatashin wrote:
The arm and arm64 versions of hypercall.h are missing the include
guards. This is needed because C inlines for privcmd_call are going to
be added to the files.
Also fix a comment.
Signed-off-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
---
arch/arm/include/asm/assembler.h | 2 +-
arch/arm/include/asm/xen/hypercall.h | 4 ++++
arch/arm64/include/asm/xen/hypercall.h | 4 ++++
include/xen/arm/hypercall.h | 6 +++---
4 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/arch/arm/include/asm/assembler.h b/arch/arm/include/asm/assembler.h
index 99929122dad7..8e9262a0f016 100644
--- a/arch/arm/include/asm/assembler.h
+++ b/arch/arm/include/asm/assembler.h
@@ -480,7 +480,7 @@ THUMB( orr \reg , \reg , #PSR_T_BIT )
.macro uaccess_disable, tmp, isb=1
#ifdef CONFIG_CPU_SW_DOMAIN_PAN
/*
- * Whenever we re-enter userspace, the domains should always be
+ * Whenever we re-enter kernel, the domains should always be
This feels unrelated from the rest of the patch and probably want an
explanation. So I think this want to be in a separate patch.
The rest of the patch looks good to me.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
