[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/6] x86/suspend: Clarify and improve the behaviour of do_suspend_lowlevel()

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 16 Dec 2019 18:24:10 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@xxxxxxxxxx; spf=Pass smtp.mailfrom=roger.pau@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Mon, 16 Dec 2019 17:24:28 +0000
  • Ironport-sdr: E7XpQd0vLXuIGNjNKl7UCP0N7otfsGvs5gyKADACJV3+9vsBk+U7WHANefvorM+MhO0j8OV2XL KIYaYQMdarpDFRFcMefoJ652A550zbL0+rcGhTTxdv5Y3uXVIoc7An1AFy4ZPWmWu/LlH/ESm3 Ucmq9tTca1cuu0qSWJ8vSBkvg+j7Eah0y3X/AlWmm3K4ViL3P3SDjATn1D3QZkFGqnCFbklthU y3amtJi36uwIkXDjwLHDrdBdtQ1D3qrOxjXdmgXSLuY3avDigo/f8bZEloX8n7rlJBZDmFnR/f c9o=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Dec 13, 2019 at 07:04:31PM +0000, Andrew Cooper wrote:
> do_suspend_lowlevel() behaves as a function call, even when the trampoline
> jumps back into the middle of it.  Discuss this property, while renaming the
> far-too-generic __ret_point to s3_resume.
> Optimise the calling logic for acpi_enter_sleep_state().  $3 doesn't require a
> 64bit write, and the function isn't variadic so doesn't need to specify zero
> FPU registers in use.
> In the case of an acpi_enter_sleep_state() error, we didn't actually lose
> state so don't need to restore it.  Jump straight to the end.
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.