[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/pv: Fix `global-pages` to match the documentation

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Mon, 16 Dec 2019 16:38:45 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@xxxxxxxxxx; spf=Pass smtp.mailfrom=roger.pau@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>
  • Delivery-date: Mon, 16 Dec 2019 15:38:55 +0000
  • Ironport-sdr: arMNTdJbsBuQ9EGX/XhUJkCCGxwle8rG2f2Tw8ARTXaISs3qjQ/z1wEvOzrHVlRUXuGgN0uY6z BsOXTtBq8L8e2kJf7p5WUqJn6Dma67staPtgX0ZIL5xBM+7XiRS2jULV4i5ECqYU3mYLkSstKo ysurdS8O/HrONgiA5z49Y4cHt/AW3Zfk3rNaT/K9TitM5DCVzkpFvnBVL1/K5gHVg2S3L9z+cu 66b8niG8UdRU0kAHDQkyYWUDFFWzIEQDSY0R9Fj4+S8k9UoxGHVzwDjDfWcDHpMKVxP5zCwXxI yAE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, Dec 16, 2019 at 02:02:27PM +0000, Andrew Cooper wrote:
> c/s 5de961d9c09 "x86: do not enable global pages when virtualized on AMD or
> Hygon hardware" in fact does.  Fix the calculation in pge_init().
> While fixing this, adjust the command line documenation, first to use the
> newer style, and to expand the description to discuss cases where the option
> might be useful to use, but Xen can't account for by default.

Fixes: 5de961d9c09 ('x86: do not enable global pages when virtualized on AMD or 
Hygon hardware')

Would be helpful for backport reasons if someone picks up the other
change (or at least I've been trying to use it in order to help
downstreams that might cherry-pick stuff).

> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.