Re: [Xen-devel] [PATCH 1/2] x86/time: drop vtsc_{kern, user}count debug counters

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Dec 13, 2019 at 10:48:01PM +0000, Igor Druzhinin wrote:
> They either need to be transformed to atomics to work correctly
> (currently they left unprotected for HVM domains) or dropped entirely
                  ^ are used
> as taking a per-domain spinlock is too expensive for high-vCPU count
> domains even for debug build given this lock is taken too often.
> 
> Choose the latter as they are not extremely important anyway.
> 
> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>

I don't find those counters specially useful TBH, but I'm not sure whether
others find them useful. The change LGTM, so:

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel