[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] Xen missing prompt log when exec-sp=off
- To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jin Nan Wang <jnwang@xxxxxxxx>
- Date: Mon, 16 Dec 2019 07:00:02 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4YvKHRegAf7N+gjcyQA4OfeY1GlwjMAyrF6aRIxvs3I=; b=iWqndqjqKHgu5yM88o3omZL48J9cJVoAPvLzL2nr+4xyypLe+jzhOUbh/qZQhd+G5aTFk0GdwuvftN00XC3hPSrpR33x8XRfczIhHZM10t6FCc/c7KED0qJJD/mlWZEOqS++U4BftpPCbht1VIEmYxDlmewpGT5rCNBtGGnsZUkjl6nAgJChJx0LeMMRL0/y8rCw+3eHLtdZE/8QHildjpWcSzuo1C9ZuSU+HhAgPn9MmAwR6L9OJ6vmTuC6ig58vE0DOarDddRW2ZI5vPcpRB5GxLdOyZg4IdORxzz8VcU3lp8QDpMq575UY105Jukab4u0KJ7RjCNYKbpcCuazww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nZBcCd+fkm6tPUIWPIxkHvZAA40a8CIeOKKMNb6PIVDoQPtCbid3s4MykqfEASYwf4rcvn60ac+1LNi6JeVJcFnq3NZ+ktVw5GYfpYTTcItLzFP2zd3/7q13PhgQWHXp4HUSFrMtqB8tXcLt6daotQ1mHMM2i6hAcAGU51oR1L/IjdxEMSD+eNNoyN68HIxT7bb2TGXIvR67YDn5ADmJKTh6ia6CgVWzzJhu1N7kDv/Mli/ry6CoC1WETFfbm5MgBkh9wHJSLQFQQoFknHLOwOons55yecuJ9ApnszNa5MCfwlyAzz9iyjl0ZCzIUq4Myk9mWHQkBdm5V5vqhx1J0w==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=jnwang@xxxxxxxx;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 16 Dec 2019 07:03:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHVs9RYvDJGD9d8eEizxnHO4Wu686e8RwQQgAAOIgA=
- Thread-topic: [PATCH] Xen missing prompt log when exec-sp=off
On 16/12/2019 2:17 pm, Tian, Kevin wrote:
>> From: Jin Nan Wang <jnwang@xxxxxxxx>
>> Sent: Monday, December 16, 2019 1:48 PM
>>
>> Fix a issue when user disable ETP exec-sp, xen missed a prompt
>> log in dmesg.
>>
>> Signed-off-by: James Wang <jnwang@xxxxxxxx>
>> ---
>> xen/arch/x86/hvm/vmx/vmx.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c
>> index 7970ba93e1..9c1f0f645d 100644
>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> @@ -2499,7 +2499,9 @@ const struct hvm_function_table * __init
>> start_vmx(void)
>> {
>> /* Default to non-executable superpages on vulnerable
>> hardware. */
>> opt_ept_exec_sp = !cpu_has_bug_pschange_mc;
>> -
>> + }
> no parenthesis then. Just move the comment before the earlier condition
> check
Got it.
>> + if (opt_ept_exec_sp == false)
>> + {
>> if ( cpu_has_bug_pschange_mc )
>> printk("VMX: Disabling executable EPT superpages due to
>> CVE-
>> 2018-12207\n");
>> }
> Can we do it another way? Always throw out a warning if the hardware
> is vulnerable, plus its enabling status?
OK. Let me try.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel
|
