[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [XEN PATCH 4/8] xen: Have Kconfig check $(CC)'s version



On Thu, Dec 12, 2019 at 06:56:00PM +0000, Andrew Cooper wrote:
> On 12/12/2019 18:27, Anthony PERARD wrote:
> > diff --git a/xen/Makefile b/xen/Makefile
> > index efbe9605e52b..0cf4ded9d9d4 100644
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -267,6 +267,7 @@ $(foreach base,arch/x86/mm/guest_walk_% \
> >                 arch/x86/mm/shadow/guest_%, \
> >      $(foreach ext,o i s,$(call build-intermediate,$(base).$(ext))))
> >  
> > +export CC LD
> 
> This probably wants to be higher up the file, where we export all the
> other variables.  Perhaps also include CXX.

I'll move that to just after "export PYTHON". (Or maybe it should be
after we include Config.mk? But it probably doesn't matter where it is.)

> Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.