Re: [Xen-devel] [PATCH] public/io/netif.h: document a mechanism to advertise carrier state

["Durrant, Paul" <pdurrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jürgen Groß <jgross@xxxxxxxx>
> Sent: 13 December 2019 14:17
> To: Durrant, Paul <pdurrant@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Subject: Re: [PATCH] public/io/netif.h: document a mechanism to advertise
> carrier state
> 
> On 13.12.19 14:03, Paul Durrant wrote:
> > This patch adds a specification for a 'carrier' node in xenstore to
> allow
> > a backend to notify a frontend of it's virtual carrier/link state. E.g.
> > a backend that is unable to forward packets from the guest because it is
> > not attached to a bridge may wish to advertise 'no carrier'.
> >
> > NOTE: This is purely a documentation patch. No functional change.
> >
> > Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
> > ---
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > Cc: Juergen Gross <jgross@xxxxxxxx>
> > ---
> >   xen/include/public/io/netif.h | 14 ++++++++++++++
> >   1 file changed, 14 insertions(+)
> >
> > diff --git a/xen/include/public/io/netif.h
> b/xen/include/public/io/netif.h
> > index 2454448baa..e587055f68 100644
> > --- a/xen/include/public/io/netif.h
> > +++ b/xen/include/public/io/netif.h
> > @@ -190,6 +190,20 @@
> >    * order as requests.
> >    */
> >
> > +/*
> > + * Link state
> > + * ==========
> > + *
> > + * The backend can advertise it is current link (carrier) state to the
> 
> s/it is/its/ ?
> 

Oh yes.

> > + * frontend using the /local/domain/X/backend/<domid>/<vif>/carrier
> node.
> 
> Hmm, I just realized that the other mentioned backend path in this file
> is wrong, it should be: /local/domain/X/backend/vif/<domid>/<vif>/...
> 
> Mind correcting that in your patch, too?
> 

Sure.

  Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel