Re: [Xen-devel] [PATCH-for-5.0 v3 6/6] hw/pci-host: Add Kconfig entry to select the IGD Passthrough Host Bridge

[Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>]

On 12/9/19 11:42 AM, Paolo Bonzini wrote:
> On 09/12/19 11:10, Durrant, Paul wrote:
> > > Signed-off-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>
> > > ---
> > > v3: Only default with Xen (Alex Williamson)
> > >
> > > I did not used 'depends on XEN' as suggested by Alex but
> > > 'default y if XEN', so one can build XEN without this feature
> > > (for example, on other ARCH than X86).
> I think what you want is achieved by
>
>         default y
>         depends on XEN && PC_I440FX
I think so, but with PC_I440FX -> PCI_I440FX ;)

It would be cleaner to pass the CONFIG_XEN_PCI_PASSTHROUGH variable to 
Kconfig and use it (use 'depends on XEN_PCI_PASSTHROUGH').
This can be another step, so if this series looks OK to you so far, do 
you mind fixing this and the comment in the previous patch noticed by 
Thomas:
- Extract it into a new file, 'hw/pci-host/igd_pt.c'.
+ Extract it into a new file, 'hw/pci-host/xen_igd_pt.c'.

Thanks!

Phil.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel