Re: [Xen-devel] [PATCH 3/6] xen/domctl: Consolidate hypercall continuation handling at the top level

[Julien Grall <julien@xxxxxxx>]

Hi,

On 05/12/2019 22:30, Andrew Cooper wrote:
> More paths are going start using hypercall continuations.  We could add extra
> calls to hypercall_create_continuation() but it is much easier to handle
> -ERESTART once at the top level.
>
> One complication is XEN_DOMCTL_shadow_op, which for XSA-97 and ABI
> compatibility in a security fix, turn a DOMCTL continuation into
> __HYPERVISOR_arch_1.  This remains as it was, gaining a comment explaining
> what is going on.
>
> With -ERESTART handling in place, the !domctl_lock_acquire() path can use the
> normal exit path, instead of opencoding a subset of it locally.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
> ---
>   xen/arch/x86/domctl.c           |  5 ++++-
>   xen/arch/x86/mm/hap/hap.c       |  3 +--
>   xen/arch/x86/mm/shadow/common.c |  3 +--
>   xen/common/domctl.c             | 19 +++++--------------
You seem to have missed the hypercall_create_continuation() call in 
iommu_do_pci_domctl().
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel