Re: [Xen-devel] [PATCH 1/2] x86/mm: factor out the code for shattering an l3 PTE

[Julien Grall <jgrall@xxxxxxxxxx>]

Hi,

On 07/12/2019 18:20, Xia, Hongyan wrote:
> hmm... if we want to make the nullification visible to the caller we
> might need to pass &. I wonder if it makes sense to simply move the
> memory allocation of pl2e into shatter_l3e as well, so that the caller
> cannot have any ideas.
AFAICT, the allocation is done when shattering the page-tables. So it 
would make sense to move it withing the shatter function. Note that you 
will need to propagate the error if there is any.

Cheers,

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel