[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] x86: relax GDT check in arch_set_info_guest()

On 06.12.2019 11:25, Andrew Cooper wrote:
> On 06/12/2019 10:14, Jan Beulich wrote:
>> It is wrong for us to check frames beyond the guest specified limit.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> I don't completely agree.  The code has been like this since it was
> introduced, and is used to check data from the domain builder (inc
> migration), and from the guests.
> At the moment, every caller is required not to pass junk in unused
> frames, and I don't see an issue with keeping this behaviour.

Keeping the behavior isn't going to break anything, yes, but it
shouldn't have been this way to begin with. I simply don't see
the value of validating data we're not consuming anyway. Perhaps
I could say "not helpful" or "pointless" instead of "wrong" ...


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.