Re: [Xen-devel] [PATCH v2 15/22] golang/xenlight: begin C to Go type marshaling

[Nick Rosbrook <rosbrookn@xxxxxxxxx>]

> So first of all, I noticed that the marshalling code for Union structs
> does what I suggest. :-)

Yeah I realized that. I must have figured out that my previous way
wasn't necessary, but forgot to go back and change it.

> I'm not super-strong on this, so I don't want to bike-shed.  But I think
> the way you generate the marshalling code for the union structs is better:
>
>         if err := x.Pae.fromC(&tmp.pae); err != nil {
>                 return err
>         }

I'll change it. I'd prefer not to have those inconsistencies in the
code generation.

Thanks,
-NR

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel