Re: [Xen-devel] [PATCH v2] x86/AMD: unbreak CPU hotplug on AMD systems without RstrFpErrPtrs

[Jan Beulich <jbeulich@xxxxxxxx>]

On 04.12.2019 00:56, Igor Druzhinin wrote:
> If the feature is not present Xen will try to force X86_BUG_FPU_PTRS
> feature at CPU identification time. This is especially noticeable in
> PV-shim that usually hotplugs its vCPUs. We either need to restrict this
> action for boot CPU only or allow secondary CPUs to modify
> forced CPU capabilities at runtime. Choose the former since modifying
> forced capabilities out of boot path leaves the system in potentially
> inconsistent state.
> 
> Signed-off-by: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Andrew,

please clarify explicitly whether you're okay with this going in
despite your earlier objection, or whether you want us to follow
the outlined alternative route (or yet some different approach).
FAOD I continue to insist that the __init not be dropped from the
two functions in question.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel