Re: [Xen-devel] [PATCH] Fix the KDD_LOG statements to use appropriate format specifier for printing uint64_t

[Wei Liu <wl@xxxxxxx>]

On Sat, Nov 30, 2019 at 03:11:18AM -0500, Julian Tuminaro wrote:
> Previous commit in kdd.c had a small issue which lead to warning/error while 
> compiling
> on 32-bit systems due to mismatch of type size while doing type cast from 
> uint64_t to
> void *
> 
> Signed-off-by: Jenish Rakholiya <rjenish@xxxxxxx>
> Signed-off-by: Julian Tuminaro <jtuminar@xxxxxxxxxxxxxx>
> ---
>  tools/debugger/kdd/kdd.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/debugger/kdd/kdd.c b/tools/debugger/kdd/kdd.c
> index 6d3febefda..3ebda9b12c 100644
> --- a/tools/debugger/kdd/kdd.c
> +++ b/tools/debugger/kdd/kdd.c
> @@ -613,7 +613,7 @@ static void get_os_info_64(kdd_state *s)
>      idt0_addr |= ((buf >> 32) & 0xffff0000);
>      idt0_addr |= (buf & 0xffff);
>  
> -    KDD_LOG(s, "idt0 addr: %p\n", (void *)idt0_addr);
> +    KDD_LOG(s, "idt0 addr: 0x%"PRIx64"\n", idt0_addr);
>  
>      /*
>       * get the page start and look for "MZ" file header - we limit the search
> @@ -621,7 +621,6 @@ static void get_os_info_64(kdd_state *s)
>       */
>  
>      base = idt0_addr & ~(PAGE_SIZE - 1);
> -    KDD_LOG(s, "%p\n", (void *)base);

Did you actually intend to delete this line?

Anyway, I have pushed this patch with Tim's ack to unblock our CI.

If you want to add this back, please submit another patch.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel